linux-kernel - Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 10:24:38 -0700
From:   Ryan Lee <ryans.lee@...imintegrated.com>
To:     Rob Herring <robh@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, <mark.rutland@....com>,
        <perex@...ex.cz>, <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Arnd Bergmann <arnd@...db.de>,
        <ckeepax@...nsource.wolfsonmicro.com>, <lars@...afoo.de>,
        <bardliao@...ltek.com>, <nh6z@...z.net>, <KCHSU0@...oton.com>,
        Axel Lin <axel.lin@...ics.com>, <romain.perier@...labora.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        <oder_chiou@...ltek.com>, <Paul.Handrigan@...rus.com>,
        <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Dylan Reid <dgreid@...gle.com>
Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier

On Mon, Apr 3, 2017 at 9:30 AM, Rob Herring <robh@...nel.org> wrote:
> On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@...imintegrated.com>
>> ---
>>
>> Changes since v4:
>>       * Removed support for SND_SOC_DAIFMT_CBS_CFM.
>>       * Fixed coding style for indention.
>>       * Removed variables if it has only one user.
>>       * Assigned ch_size directly.
>>       * Removed oring.
>>       * Put the return false in the switch statement.
>>       * Removed 'Monomix Output' and 'Speaker Source' controls.
>>       * Modified control names per control-names.rst.
>>       * Moved Revision ID check code to i2c_probe function.
>>       * Added 'Current Limit' control.
>>       * Removed 'devm__kfree' function.
>>
>> Changes since v3:
>>       * Combined MAX98926 and MAX98927 binding. Kept existing property name.
>
> This looks fine, but:
>
>> Changes since v2:
>>       * Removed local register read/write function to avoid duplication of ASoC core function.
>>
>>  .../devicetree/bindings/sound/max98925.txt         |  22 -
>>  .../devicetree/bindings/sound/max98926.txt         |  32 -
>>  .../devicetree/bindings/sound/max9892x.txt         |  41 +
>>  sound/soc/codecs/Kconfig                           |   5 +
>>  sound/soc/codecs/Makefile                          |   2 +
>>  sound/soc/codecs/max98927.c                        | 841 +++++++++++++++++++++
>>  sound/soc/codecs/max98927.h                        | 272 +++++++
>>  7 files changed, 1161 insertions(+), 54 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt
>>  delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt
>>  create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt
>>  mode change 100644 => 100755 sound/soc/codecs/Kconfig
>>  mode change 100644 => 100755 sound/soc/codecs/Makefile
>>  create mode 100755 sound/soc/codecs/max98927.c
>>  create mode 100755 sound/soc/codecs/max98927.h
>
> These should all be 644 mode.

I've changed the mode to 644. Thank you.

>
> Rob