linux-kernel - Re: [PATCH 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer is not DMA'ble

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2017 18:56:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vignesh R <vigneshr@...com>
Cc:     kbuild-all@...org, Mark Brown <broonie@...nel.org>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, Vignesh R <vigneshr@...com>
Subject: Re: [PATCH 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer
 is not DMA'ble

Hi Vignesh,

[auto build test WARNING on spi/for-next]
[also build test WARNING on v4.11-rc5 next-20170404]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vignesh-R/spi-ti-qspi-Handle-vmalloc-d-buffers/20170403-030332
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   drivers//spi/spi-ti-qspi.c: In function 'ti_qspi_dma_bounce_buffer':
   drivers//spi/spi-ti-qspi.c:440:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> drivers//spi/spi-ti-qspi.c:449:21: warning: comparison of distinct pointer types lacks a cast [enabled by default]
   drivers//spi/spi-ti-qspi.c:455:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

vim +449 drivers//spi/spi-ti-qspi.c

   434	}
   435	
   436	static int ti_qspi_dma_bounce_buffer(struct ti_qspi *qspi,
   437					     struct spi_flash_read_message *msg)
   438	{
   439		size_t readsize = msg->len;
 > 440		unsigned int to = (unsigned int)msg->buf;
   441		dma_addr_t dma_src = qspi->mmap_phys_base + msg->from;
   442		int ret = 0;
   443	
   444		/*
   445		 * Use bounce buffer as FS like jffs2, ubifs may pass
   446		 * buffers that does not belong to kernel lowmem region.
   447		 */
   448		while (readsize != 0) {
 > 449			size_t xfer_len = min(QSPI_DMA_BUFFER_SIZE, readsize);
   450	
   451			ret = ti_qspi_dma_xfer(qspi, qspi->rx_bb_dma_addr,
   452					       dma_src, xfer_len);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48046 bytes)