[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 4 Apr 2017 13:16:01 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Casey Schaufler <casey@...aufler-ca.com>,
Eric Paris <eparis@...isplace.org>,
James Morris <james.l.morris@...cle.com>,
Paul Moore <paul@...l-moore.com>,
"Serge E. Hallyn" <serge@...lyn.com>,
Stephen Smalley <sds@...ho.nsa.gov>,
William Roberts <william.c.roberts@...el.com>,
linux-security-module@...r.kernel.org, selinux@...ho.nsa.gov
Cc: LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: [PATCH 3/3] selinux: Use an other error code for an input validation
failure in sidtab_insert()
From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 4 Apr 2017 12:23:41 +0200
The error code "-ENOMEM" was also returned so far when the parameter "s"
of this function contained a null pointer.
Now I find that the code "-EINVAL" is more appropriate in this case.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
security/selinux/ss/sidtab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/ss/sidtab.c b/security/selinux/ss/sidtab.c
index c5f436b15d19..2eb2a54b88d2 100644
--- a/security/selinux/ss/sidtab.c
+++ b/security/selinux/ss/sidtab.c
@@ -36,7 +36,7 @@ int sidtab_insert(struct sidtab *s, u32 sid, struct context *context)
struct sidtab_node *prev, *cur, *newnode;
if (!s)
- return -ENOMEM;
+ return -EINVAL;
hvalue = SIDTAB_HASH(sid);
prev = NULL;
--
2.12.2
Powered by blists - more mailing lists