[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 04 Apr 2017 11:30:38 +0900
From: Andi Shyti <andi.shyti@...sung.com>
To: Alexey Ignatov <lexszero@...il.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Sean Young <sean@...s.org>
Subject: Re: [PATCH] [media] lirc_dev: fix regression in feature check logic in
ioctl
Hi Alexey,
this has been already fixed in commit bd291208d7f5 ("[media]
lirc_dev: LIRC_{G,S}ET_REC_MODE do not work") by Sean.
You need to update your kernel or cherry-pick this patch.
In any case, for future patches of this kind, some notes through
the lines:
On Tue, Apr 04, 2017 at 02:19:16AM +0300, Alexey Ignatov wrote:
> Commit 273b902a5b1bfd6977a73c4de3eb96db3cb103cb removed inversion in
References to commit should be of the kind:
Commit 273b902a5b1b ("[media] lirc_dev: use LIRC_CAN_REC() define
to check if the device can receive")
Please run checkpatch.pl before sending the patch.
> features check conditionals (by accident, perhaps). That change resulted
> in erroneous reporting that device can't receive while actually it can.
> Fix this.
>
> Signed-off-by: Alexey Ignatov <lexszero@...il.com>
Here goes:
Fixes: 273b902a5b1b ("[media] lirc_dev: use LIRC_CAN_REC() define to check if the device can receive")
Cc: <stable@...r.kernel.org>
because it fixes a bug (check Sean's patch).
Thanks,
Andi
Powered by blists - more mailing lists