[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 4 Apr 2017 16:43:19 +0200
From: Niklas Cassel <niklas.cassel@...s.com>
To: Corentin Labbe <clabbe.montjoie@...il.com>, <shuah@...nel.org>,
<davem@...emloft.net>, <andrew@...n.ch>,
<linux-kselftest@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] selftests: add a generic testsuite for ethernet device
On 04/04/2017 03:32 PM, Corentin Labbe wrote:
> This patch add a generic testsuite for testing ethernet network device driver.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
>
> Changes since v1:
> - Test for starting master interface
> - Changed printing format to "RESULT: $netdev: line"
> - Use "ip link" to get device list
>
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/netdevice.sh | 200 +++++++++++++++++++++++++++++++
> 2 files changed, 201 insertions(+), 1 deletion(-)
> create mode 100755 tools/testing/selftests/net/netdevice.sh
>
(snip)
Good work!
I suggest adding a test for setting MTU as well.
It doesn't have to be added before merging, but it
would be great if it could be added in the near future.
Regards,
Niklas
Powered by blists - more mailing lists