linux-kernel - Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2017 12:12:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-usb@...r.kernel.org,
        p.zabel@...gutronix.de, swarren@...dotorg.org,
        thierry.reding@...il.com, balbi@...nel.org,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Subject: Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Vivek,

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.11-rc5 next-20170403]
[cannot apply to pza/reset/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Vivek-Gautam/reset-APIs-to-manage-a-list-of-resets/20170404-111639
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x008-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/reset/core.c: In function 'reset_control_array_deassert':
   drivers/reset/core.c:526:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
     for (i = 0; i < num_rsts; i++)
     ^~~
   drivers/reset/core.c:528:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'for'
      if (ret)
      ^~
>> drivers/reset/core.c:531:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return 0;
            ^

vim +/ret +531 drivers/reset/core.c

   520	{
   521		int ret, i;
   522	
   523		if (WARN_ON(IS_ERR_OR_NULL(resets)))
   524			return -EINVAL;
   525	
 > 526		for (i = 0; i < num_rsts; i++)
   527			ret = reset_control_deassert(resets[i].rst);
   528			if (ret)
   529				goto err;
   530	
 > 531		return 0;
   532	
   533	err:
   534		while (--i >= 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25352 bytes)