linux-kernel - RE: [PATCH] unisys: visornic: Replace symbolic perms with octal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Apr 2017 12:45:02 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Thomas Jespersen <laumann.thomas@...il.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>,
        "Frisch, Jon" <Jon.Frisch@...sys.com>,
        "erik.arfvidson@...sys.com" <erik.arfvidson@...sys.com>,
        *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] unisys: visornic: Replace symbolic perms with octal

> -----Original Message-----
> From: Thomas Jespersen [mailto:laumann.thomas@...il.com]
> Sent: Tuesday, April 4, 2017 3:15 PM
> To: Kershner, David A <David.Kershner@...sys.com>
> Cc: gregkh@...uxfoundation.org; Sell, Timothy C
> <Timothy.Sell@...sys.com>; Binder, David Anthony
> <David.Binder@...sys.com>; Frisch, Jon <Jon.Frisch@...sys.com>;
> erik.arfvidson@...sys.com; *S-Par-Maintainer
> <SParMaintainer@...sys.com>; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal
> 

Should the subject line say "staging: unisys: visornic" instead of just 
"unisys: visornic:"?

Besides that, I'm fine with this patch and have tested it on s-Par. 

David Kershner

> Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
> counterparts
> 
> Signed-off-by: Thomas Jespersen <laumann.thomas@...il.com>
> ---
>  drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c
> b/drivers/staging/unisys/visornic/visornic_main.c
> index feece91..1008337 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -2146,11 +2146,11 @@ static int visornic_init(void)
>  	if (!visornic_debugfs_dir)
>  		return err;
> 
> -	ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir,
> NULL,
> +	ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
>  				  &debugfs_info_fops);
>  	if (!ret)
>  		goto cleanup_debugfs;
> -	ret = debugfs_create_file("enable_ints", S_IWUSR,
> visornic_debugfs_dir,
> +	ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
>  				  NULL, &debugfs_enable_ints_fops);
>  	if (!ret)
>  		goto cleanup_debugfs;
> --
> 2.10.2