linux-kernel - Re: [PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2017 15:45:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Varsha Rao <rvarsha016@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers: char: Replace bit operation functions with
 IDA allocator.

On Mon, Apr 10, 2017 at 12:28:59PM +0530, Varsha Rao wrote:
> Replace bit operation functions with IDA allocator functions. As IDA
> allocation is simpler, faster, more space efficient and it generates
> small integer IDs which can be used as minor device numbers.

The allocation is different than the bitfield searching is?  How
exactly?  What is the old result vs. the new result of this change?

How did you test this?

You have to really sell this change, right now it looks pretty
pointless...

thanks,

greg k-h