linux-kernel - Re: [patch 3/3] x86/vdso: Sanitize vdso*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Apr 2017 18:25:44 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andy Lutomirski <luto@...capital.net>
cc:     LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Mathias Krause <minipli@...glemail.com>
Subject: Re: [patch 3/3] x86/vdso: Sanitize vdso*_enabled handling

On Mon, 10 Apr 2017, Andy Lutomirski wrote:

> On Mon, Apr 10, 2017 at 8:14 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > +static int vdso32_sysctl;
> > +
> > +static int vdso_update_handler(struct ctl_table *table, int write,
> > +                              void __user *buffer, size_t *lenp,
> > +                              loff_t *ppos)
> > +{
> > +       int ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
> 
> Using a global for the temporary is gross and mildly racy.  I would
> just open-code the conversion.  Or, even better, add proc_dobool().

Dammit, thought about it and then got lazy. :(

Thanks,

	tglx