linux-kernel - Re: [PATCH] sched: Enabled schedstat when schedstat tracepoints are enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2017 10:02:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     kbuild-all@...org, Mel Gorman <mgorman@...e.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Subject: Re: [PATCH] sched: Enabled schedstat when schedstat tracepoints are
 enabled

Hi Steven,

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.11-rc6 next-20170412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Steven-Rostedt/sched-Enabled-schedstat-when-schedstat-tracepoints-are-enabled/20170413-082900
config: i386-randconfig-x006-201715 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> kernel/sched/core.c:2289:5: error: redefinition of 'schedstat_tracepoint_reg'
    int schedstat_tracepoint_reg(void)
        ^~~~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/sched/core.c:8:0:
   include/linux/sched.h:1463:19: note: previous definition of 'schedstat_tracepoint_reg' was here
    static inline int schedstat_tracepoint_reg(void) { return 0; }
                      ^~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/sched/core.c:2299:6: error: redefinition of 'schedstat_tracepoint_unreg'
    void schedstat_tracepoint_unreg(void)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/sched/core.c:8:0:
   include/linux/sched.h:1464:20: note: previous definition of 'schedstat_tracepoint_unreg' was here
    static inline void schedstat_tracepoint_unreg(void) { }
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/core.c: In function 'schedstat_tracepoint_reg':
   kernel/sched/core.c:2297:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/schedstat_tracepoint_reg +2289 kernel/sched/core.c

  2283	 * regfunc/unregfunc functions. They are protected by the tracepoint mutex.
  2284	 *     See kernel/tracepoint.c:tracepoint_add_func().
  2285	 *
  2286	 * The modifications to schedstat_tracepoint_ref and schedstat_save_state
  2287	 * are only done under that mutex, and do not need further protection.
  2288	 */
> 2289	int schedstat_tracepoint_reg(void)
  2290	{
  2291		if (!schedstat_tracepoint_ref) {
  2292			schedstat_save_state = schedstat_enabled();
  2293			if (!schedstat_save_state)
  2294				set_schedstats(true);
  2295		}
  2296		schedstat_tracepoint_ref++;
  2297	}
  2298	
> 2299	void schedstat_tracepoint_unreg(void)
  2300	{
  2301		schedstat_tracepoint_ref--;
  2302		if (schedstat_tracepoint_ref || schedstat_save_state)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29893 bytes)