linux-kernel - Re: [PATCH 2/2] kbuild: fix asm-offset generation to work with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2017 10:44:58 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org, David Howells <dhowells@...hat.com>,
        Michael Davidson <md@...gle.com>,
        Michal Marek <mmarek@...e.com>,
        Jan Beulich <JBeulich@...ell.com>,
        Alexander van Heukelum <heukelum@...tmail.fm>,
        Jeroen Hofstee <jeroen@...pectrum.nl>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] kbuild: fix asm-offset generation to work with clang

El Fri, Apr 14, 2017 at 02:50:03PM +0900 Masahiro Yamada ha dit:

> From: Jeroen Hofstee <jeroen@...pectrum.nl>
> 
> KBuild abuses the asm statement to write to a file and
> clang chokes about these invalid asm statements. Hack it
> even more by fooling this is actual valid asm code.
> 
> Signed-off-by: Jeroen Hofstee <jeroen@...pectrum.nl>
> [masahiro:
>  Import Jeroen's work for U-Boot:
>  http://patchwork.ozlabs.org/patch/375026/
>  Tweak sed script a little to drop garbage '#' for GCC case, like
>  #define NR_PAGEFLAGS 23 /* __NR_PAGEFLAGS       # */ ]
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
Tested-by: Matthias Kaehlcke <mka@...omium.org>

I tested with x86 and arm64. Please note that two more changes are
needed to avoid breaking frv and um:

https://patchwork.kernel.org/patch/9660473/
https://patchwork.kernel.org/patch/9660503/

Maybe these should be part of your patch set? I only sent them out
separately to avoid cross posting with my initial patch for this issue
being a RFC.

Cheers

Matthias