linux-kernel - Re: [PATCH] x86/mpx, selftests: Only check bounds-vs-shadow when we keep shadow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2017 12:51:46 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Joerg Roedel <joro@...tes.org>, Shuah Khan <shuah@...nel.org>,
        Ingo Molnar <mingo@...nel.org>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH] x86/mpx, selftests: Only check bounds-vs-shadow when we
 keep shadow

On 04/06/2017 07:23 AM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@...e.de>
> 
> The check between the hardware state and our shadow of it is
> checked in the signal handler for all bounds exceptions,
> even for the ones where we don't keep the shadow up2date.
> This is a problem because when no shadow is kept the handler
> fails at this point and hides the real reason of the
> exception.
> 
> Move the check into the code-path evaluating normal bounds
> exceptions to prevent this.

Looks good to me.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>