linux-kernel - Re: [PATCH] cgroup: define empty cftype structure for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2017 15:56:36 -0600
From:   Jens Axboe <axboe@...com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Paolo Valente <paolo.valente@...aro.org>,
        Tejun Heo <tj@...nel.org>, "Li Zefan" <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Daniel Mack <daniel@...que.org>,
        Ingo Molnar <mingo@...nel.org>, <cgroups@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: define empty cftype structure for !CONFIG_CGROUPS

On 04/21/2017 03:41 PM, Arnd Bergmann wrote:
> There is a new forward declaration for two global cftype arrays, but
> that fails to build when CONFIG_CGROUPS is disabled:
> 
> In file included from /git/arm-soc/block/bfq-iosched.c:105:0:
> block/bfq-iosched.h:820:22: error: array type has incomplete element type 'struct cftype'
>  extern struct cftype bfq_blkcg_legacy_files[];
>  extern struct cftype bfq_blkg_files[];
> 
> This adds an empty definition for the type to make it build again.

This was already fixed up yesterday:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.12/block&id=659b3394eb67a5e274d7e7348633b508510a5c8f

-- 
Jens Axboe