linux-kernel - Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 08:30:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sekhar Nori <nsekhar@...com>, Jonathan Cameron <jic23@...nel.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tools/iio: Use include/uapi with __EXPORTED_HEADERS__

On 04/24/17 04:40, Sekhar Nori wrote:
> Hi Randy,
> 
> On Sunday 23 April 2017 07:52 AM, Randy Dunlap wrote:
>> On 04/21/17 05:31, Sekhar Nori wrote:
>>> Use the local uapi headers to keep in sync with "recently" added enum
>>> values like IIO_UVINDEX.
>>>
>>> Build tested using:
>>> $ make -C <kernelsrcdir> tools/iio
>>> $ make -C <kernelsrcdir>/tools iio
>>> $ make -C <kernelsrcdir>/tools/iio
>>
>> Hi,
>> Did you do any testing with O=<outputdir> ?
> 
> I hadn't, but I just checked with:
> 
> $ make -C <kernelsrcdir>/tools iio O=<outputdir>
> 
> Although there is an iio folder created under <outputdir>, the actual
> binaries are still built under <kernelsrcdir>/tools/iio. So I think
> there is some more work to be done to respect the O= option passed from
> command line.
> 
> The behavior remains same with or without my patch.

Yes, agreed.  This is a common problem in tools.

Thanks.

-- 
~Randy