linux-kernel - Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 12:03:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     fengguang.wu@...el.com
Cc:     sudarsana.kalluru@...ium.com, kbuild-all@...org,
        netdev@...r.kernel.org, Yuval.Mintz@...ium.com,
        Ariel.Elior@...ium.com, everest-linux-l2@...ium.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

From: kbuild test robot <fengguang.wu@...el.com>
Date: Fri, 21 Apr 2017 08:20:07 +0800

> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset
> 
> 
>  Use kzalloc rather than kmalloc followed by memset with 0
> 
>  This considers some simple cases that are common and easy to validate
>  Note in particular that there are no ...s in the rule, so all of the
>  matched code has to be contiguous
> 
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> CC: sudarsana.kalluru@...ium.com <sudarsana.kalluru@...ium.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

I intentionally let this change happen.

It was less risky than asking the submitter who introduced it to
make another respin to keep the kzalloc().