linux-kernel - patch series moving compat syscalls from fs/compat.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 10:31:34 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus <torvalds@...ux-foundation.org>
Subject: patch series moving compat syscalls from fs/compat.c

Hi Al,

I couldn't easily find this patch series posted anywhere (I didn't try
too hard) so I sill just comment here.  I first noticed them in the vfs
tree in linux-next today.

Overall, I like what they day, but when I first created kernel/compat.c
(in 2002), Linus did not want the compat code sprinkled all over the
other files (due to the uglifiying effect of #ifdefs in the C code, and
because the compat layer was only secondary).  He may have changed his
mind since then, but it is worth asking.  The cleanups (including more
static functions) make it worth while for me, at least.

It also might have been worth asking the original (and subsequent)
authors of the code for review and/or comments.

One thing I noticed from a quick look: do_handle_open() could now be static.

-- 
Cheers,
Stephen Rothwell