linux-kernel - Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 10:02:05 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Shuah Khan <shuah@...nel.org>
Cc:     priyalee.kushwaha@...el.com, josh@...htriplett.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Kushwaha@...04-pco.easydns.vpn, ldr709@...il.com
Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

On Mon, Apr 24, 2017 at 08:02:10AM -0600, Shuah Khan wrote:
> On 04/22/2017 11:17 AM, priyalee.kushwaha@...el.com wrote:
> > From: Priyalee Kushwaha <priyalee.kushwaha@...el.com>
> > 
> > Most OS distribution have awk in /usr/bin not in /bin
> > Without this patch, kernel-devsrc fails to build as
> > runtime dependency for srcu-cbmc script /bin/awk is
> > not found.
> > 
> > Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@...el.com>
> > ---
> >  tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > index 8ff8904..c9e8bc5 100755
> > --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> > @@ -1,4 +1,4 @@
> > -#!/bin/awk -f
> > +#!/usr/bin/awk -f
> >  
> >  # Modify SRCU for formal verification. The first argument should be srcu.h and
> >  # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the
> > 
> 
> Hi Paul,
> 
> If this change looks good, please Ack it so I can take it through kselftest
> tree. If you would like to take this through rcu, that is fine as well.

Hello, Shuah,

I have queued it with Lance's ack and Josh's review.

Just for full disclosure, my recent SRCU work has broken srcu-cbmc,
and a bit more breakage is on its way.  :-(

That said, I would welcome patches to fix it -- mostly adjustments in
pathnames, structure names, and which fields get removed.  Adjusting it
to work correctly with Classic SRCU would probably be a bit easier than
adapting it to either Tree SRCU or Tiny SRCU.

							Thanx, Paul