linux-kernel - [tip:perf/core] x86/fpu: Fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2017 13:54:42 -0700
From:   tip-bot for kbuild test robot <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     bp@...e.de, fenghua.yu@...el.com, riel@...hat.com,
        fengguang.wu@...el.com, yu-cheng.yu@...el.com, mingo@...nel.org,
        hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
        dave.hansen@...ux.intel.com
Subject: [tip:perf/core] x86/fpu: Fix boolreturn.cocci warnings

Commit-ID:  9908f0103652690a7a17f3da415859320e88edc3
Gitweb:     http://git.kernel.org/tip/9908f0103652690a7a17f3da415859320e88edc3
Author:     kbuild test robot <fengguang.wu@...el.com>
AuthorDate: Mon, 6 Mar 2017 08:45:53 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 6 Mar 2017 11:52:47 +0100

x86/fpu: Fix boolreturn.cocci warnings

arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Rik van Riel <riel@...hat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Cc: Fenghua Yu <fenghua.yu@...el.com>
Cc: Rik van Riel <riel@...hat.com>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Yu-cheng Yu <yu-cheng.yu@...el.com>
Cc: kbuild-all@...org
Cc: tipbuild@...or.com
Cc: Borislav Petkov <bp@...e.de>
Link: http://lkml.kernel.org/r/20170306004553.GA25764@lkp-wsm-ep1
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 arch/x86/kernel/fpu/xstate.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 2e89383..b269492 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -928,12 +928,12 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey,
 static inline bool xfeatures_mxcsr_quirk(u64 xfeatures)
 {
 	if (!(xfeatures & (XFEATURE_MASK_SSE|XFEATURE_MASK_YMM)))
-		return 0;
+		return false;
 
 	if (xfeatures & XFEATURE_MASK_FP)
-		return 0;
+		return false;
 
-	return 1;
+	return true;
 }
 
 /*