linux-kernel - [PATCH] parse-events: Fix the FALSE case in pevent_filter_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2017 23:55:40 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>
Subject: [PATCH] parse-events: Fix the FALSE case in pevent_filter_clear_trivial()

Currently the FILTER_TRIVIAL_FALSE hasn't break statement
so if the trivial type is FALSE, it'll be hit always.

So add break statement at the FALSE case
to correctly remove trivial filters.

Reported-by: Namhyung Kim <namhyung@...nel.org>
Signed-off-by: Taeung Song <treeze.taeung@...il.com>
---
 parse-filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/parse-filter.c b/parse-filter.c
index 7c214ce..c2fd26f 100644
--- a/parse-filter.c
+++ b/parse-filter.c
@@ -1634,6 +1634,7 @@ int pevent_filter_clear_trivial(struct event_filter *filter,
 		case FILTER_TRIVIAL_FALSE:
 			if (filter_type->filter->boolean.value)
 				continue;
+			break;
 		case FILTER_TRIVIAL_TRUE:
 			if (!filter_type->filter->boolean.value)
 				continue;
-- 
2.7.4