linux-kernel - RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2017 16:42:02 +0000
From:   "Gao, Bin" <bin.gao@...el.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sathyaosid@...il.com" <sathyaosid@...il.com>
Subject: RE: [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ status mask

On Wed, April 26, 2017 at 7:26 AM, Linus Walleij wrote:
>On Mon, Apr 24, 2017 at 9:15 PM,
><sathyanarayanan.kuppuswamy@...ux.intel.com> wrote:
>
>> From: Kuppuswamy Sathyanarayanan 
>> <sathyanarayanan.kuppuswamy@...ux.intel.com>
>>
>> According to Whiskey Cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to 
>> battery IO. So we should skip this bit when checking for GPIO IRQ 
>> pending status. Otherwise, wcove_gpio_irq_handler() might go into the 
>> infinite loop until IRQ "pending" status becomes 0. This patch fixes this issue.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan 
>> <sathyanarayanan.kuppuswamy@...ux.intel.com>
>
>Looks fine to me, tentatively applied.
>
>Bin, Mika, Andy, OK?
>
>Yours,
>Linus Walleij

Looks reasonable to me.

Thanks,
Bin