linux-kernel - Re: [PATCH] x86/intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2017 00:36:42 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     "David E. Box" <david.e.box@...ux.intel.com>,
        jacob.jun.pan@...ux.intel.com
Cc:     lenb@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] x86/intel_idle: add GLK support

On Saturday, April 22, 2017 11:06:25 PM David E. Box wrote:
> From: "Box, David E" <david.e.box@...el.com>
> 
> Gemini Lake uses the same C-states as Broxton and also uses the
> IRTL MSR's to determine maximum C-state latency.
> 
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>

You could use the code names consistently in your subjects (but I can fix this up).

Jacob, any concerns?

> ---
>  drivers/idle/intel_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index e045a5c..778af71 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>  	ICPU(INTEL_FAM6_XEON_PHI_KNL,		idle_cpu_knl),
>  	ICPU(INTEL_FAM6_XEON_PHI_KNM,		idle_cpu_knl),
>  	ICPU(INTEL_FAM6_ATOM_GOLDMONT,		idle_cpu_bxt),
> +	ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE,	idle_cpu_bxt),
>  	ICPU(INTEL_FAM6_ATOM_DENVERTON,		idle_cpu_dnv),
>  	{}
>  };
> @@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
>  		ivt_idle_state_table_update();
>  		break;
>  	case INTEL_FAM6_ATOM_GOLDMONT:
> +	case INTEL_FAM6_ATOM_GEMINI_LAKE:
>  		bxt_idle_state_table_update();
>  		break;
>  	case INTEL_FAM6_SKYLAKE_DESKTOP:
>