linux-kernel - RE: [PATCH -next] ASoC: Intel: Skylake: Fix to use list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Apr 2017 05:39:06 +0000
From:   "weiyongjun (A)" <weiyongjun1@...wei.com>
To:     Vinod Koul <vinod.koul@...el.com>
CC:     Wei Yongjun <weiyj.lk@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        Pardha Saradhi K <pardha.saradhi.kesapragada@...el.com>,
        G Kranthi <gudishax.kranthikumar@...el.com>,
        Hardik T Shah <hardik.t.shah@...el.com>,
        Jeeja KP <jeeja.kp@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] ASoC: Intel: Skylake: Fix to use
 list_for_each_safe() when delete items



> -----Original Message-----
> From: Vinod Koul [mailto:vinod.koul@...el.com]
> Sent: Wednesday, April 26, 2017 1:38 PM
> To: weiyongjun (A) <weiyongjun1@...wei.com>
> Cc: Wei Yongjun <weiyj.lk@...il.com>; Liam Girdwood
> <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; Jaroslav
> Kysela <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Pardha Saradhi K
> <pardha.saradhi.kesapragada@...el.com>; G Kranthi
> <gudishax.kranthikumar@...el.com>; Hardik T Shah
> <hardik.t.shah@...el.com>; Jeeja KP <jeeja.kp@...el.com>; alsa-
> devel@...a-project.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH -next] ASoC: Intel: Skylake: Fix to use
> list_for_each_safe() when delete items
> 
> On Tue, Apr 25, 2017 at 07:57:57AM +0000, weiyongjun (A) wrote:
> > > >
> > > > Since we will remove items off the list using list_del() we need
> > > > to use a safe version of the list_for_each() macro aptly named
> > > > list_for_each_safe().
> > >
> > > ah yes, god catch
> > >
> > > > This is detected by Coccinelle semantic patch.
> > >
> > > It is a good practice to include the script you used, do you mind adding
> > > that in the log?
> > >
> >
> > Sure.
> 
> Sorry I meant this should be in changelog of the patch :)

OK, I will add this and send the v2 version patch later.