linux-kernel - Re: [PATCH 3/8] selftests: futex: override clean in lib.mk to fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Apr 2017 15:57:13 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     shuah@...nel.org, bamvor.zhangjian@...aro.org,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        viro@...iv.linux.org.uk, emilio.lopez@...labora.co.uk,
        mingo@...nel.org, luto@...nel.org, dave.hansen@...ux.intel.com,
        dsafonov@...tuozzo.com, rkrcmar@...hat.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 3/8] selftests: futex: override clean in lib.mk to fix
 warnings

On 04/27/2017 03:54 PM, Darren Hart wrote:
> On Fri, Apr 21, 2017 at 05:14:45PM -0600, Shuah Khan wrote:
>> Add override for lib.mk clean to fix the following warnings from clean
>> target run.
>>
>> Makefile:36: warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
>> ---
>>  tools/testing/selftests/futex/Makefile | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index c8095e6..e2fbb89 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -32,9 +32,10 @@ override define EMIT_TESTS
>>  	echo "./run.sh"
>>  endef
>>  
>> -clean:
>> +override define CLEAN
>>  	for DIR in $(SUBDIRS); do		\
>>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>>  		mkdir $$BUILD_TARGET  -p;	\
>>  		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>>  	done
>> +endef
> 
> Taking the move of clean into lib.mk as a given,

Yeah I considered undoing that, and chose to fix the missed
issues instead.
> 
> Acked-by: Darren Hart (VMware) <dvhart@...radead.org>
> 

thanks,
-- Shuah