linux-kernel - Re: [PATCH] pwm: sun4i: switch to atomic PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 11:06:38 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Olliver Schinagl <o.schinagl@...imaker.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: sun4i: switch to atomic PWM

On Fri, Apr 28, 2017 at 12:00:02AM +0200, Alexandre Belloni wrote:
> Switch the driver to atomic PWM. This makes it easier to wait a proper
> amount of time when changing the duty cycle before disabling the channel
> (main use case is switching the duty cycle to 0 before disabling).
> 
> Also, the hardware read out is now greatly improved as it was formerly only
> handling PWM polarity.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

You have a bunch of checkpatch warnings, please fix them.

Once done, you have my reviewed-by.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)