linux-kernel - Re: [PATCH 1/2] input: touchscreen: ar1021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 10:02:00 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Martin Kepplinger <martin.kepplinger@...zinger.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] input: touchscreen: ar1021_i2c: enable touch mode
 during open

On Thu, Apr 27, 2017 at 02:22:35PM +0200, Martin Kepplinger wrote:
> The device could as well be in command mode, in which this driver cannot
> handle the device. When opening the device, let's make sure the device
> will be in the mode we expect it to be for this driver.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...zinger.com>
> ---
>  drivers/input/touchscreen/ar1021_i2c.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index 1a94d8b..2a76231 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -18,6 +18,12 @@
>  #define AR1021_MAX_X	4095
>  #define AR1021_MAX_Y	4095
>  
> +#define AR1021_CMD	0x55
> +#define AR1021_TOUCH	0x80
> +
> +#define AR1021_CMD_ENABLE_TOUCH		0x12
> +#define AR1021_CMD_DISABLE_TOUCH	0x13
> +
>  struct ar1021_i2c {
>  	struct i2c_client *client;
>  	struct input_dev *input;
> @@ -58,6 +64,15 @@ static int ar1021_i2c_open(struct input_dev *dev)
>  {
>  	struct ar1021_i2c *ar1021 = input_get_drvdata(dev);
>  	struct i2c_client *client = ar1021->client;
> +	int error;
> +	u8 cmd_enable_touch[3] = {AR1021_CMD,
> +				  0x01, /* number of bytes after this */
> +				  AR1021_CMD_ENABLE_TOUCH };

Changed to static const and applied, thank you.

> +
> +	error = i2c_master_send(ar1021->client, cmd_enable_touch,
> +				sizeof(cmd_enable_touch));
> +	if (error < 0)
> +		return error;
>  
>  	enable_irq(client->irq);
>  
> -- 
> 2.1.4
> 

-- 
Dmitry