linux-kernel - nvdimm/pmem device lifetime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 07:37:54 +0300
From:   Mika Penttilä <mika.penttila@...tfour.com>
To:     LKML <linux-kernel@...r.kernel.org>,
        Dan Williams <dan.j.williams@...el.com>
Subject: nvdimm/pmem device lifetime

Hi,

Just wondering the pmem struct device vs gendisk lifetimes.. from pmem_attach_disk():

        device_add_disk(dev, disk);
	devm_add_action_or_reset(dev, pmem_release_disk, disk);

where:
static void pmem_release_disk(void *disk)
{
        del_gendisk(disk);
        put_disk(disk);
}

but device_add_disk() makes disk pin dev (as a parent), and it's unpinned by del_gendisk()
which is called when dev is released, but it's not because of this circular dependency?

--Mika