linux-kernel - Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Apr 2017 09:05:15 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc
 entry

Hello Andy,

Thus wrote Andy Shevchenko (andy.shevchenko@...il.com):

> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@...ser.cx> wrote:

> > checkpatch is asking for a 4 digit octal number. And at least for me,
> > 0444 makes it clearer what the permissions actually are. Yes, somewhere
> > in the code, I can dig up that 0 is changed to 0444...

> Aren't 0 and 0444 different by meaning?

my undestanding is that proc_create() calls proc_create_data(), where

   if ((mode & S_IALLUGO) == 0)
      mode |= S_IRUGO;

sets mode to 0444 when it was 0.

Best regards,
Martin

(added the lkml back to Cc, I removed it by accident in an earlier mail)