linux-kernel - Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Apr 2017 17:12:33 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Toshi Kani <toshi.kani@....com>
Cc:     Dave Jiang <dave.jiang@...el.com>,
        Vishal L Verma <vishal.l.verma@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison()

On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@....com> wrote:
>> Badblocks are tracked at both region and device levels.
>> pmem_clear_poison() and nsio_rw_bytes() call nvdimm_clear_poison()
>> and then badblocks_clear() to clear badblocks at the device level.
>> However, it does not update badblocks at the region level, which
>> makes them inconsistent.
>>
>> Change nvdimm_clear_poison() to update backblocks at the region
>> level to keep them consistent.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@....com>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> Cc: Dave Jiang <dave.jiang@...el.com>
>> Cc: Vishal Verma <vishal.l.verma@...el.com>
>
> This looks good, and it seems we have a bug in the other location that
> does this in __nd_ioctl(). That other one is missing the
> "clear_err.cleared / 512" check. Can you respin this and define a
> common helper that both locations can call?

On second thought, I'll take this and spin my own cleanup / fix on top.

Thanks Toshi!