linux-kernel - [PATCH 8/9] clocksource/drivers/fttmr010: Drop unnecessary static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  4 May 2017 22:10:53 +0200
From:   Julia Lawall <Julia.Lawall@...6.fr>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     keescook@...omium.org, kernel-janitors@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: [PATCH 8/9] clocksource/drivers/fttmr010: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any use, on every possible execution path through the function.  The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
   1777    4352      20    6149    1805 drivers/clocksource/timer-fttmr010.o

after:
   text    data     bss     dec     hex filename
   1770    4352      12    6134    17f6 drivers/clocksource/timer-fttmr010.o

Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

---
 drivers/clocksource/timer-fttmr010.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index b4a6f1e..055c65e 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -263,7 +263,7 @@ static int __init fttmr010_timer_of_init(struct device_node *np)
 
 static int __init gemini_timer_of_init(struct device_node *np)
 {
-	static struct regmap *map;
+	struct regmap *map;
 	int ret;
 	u32 val;