linux-kernel - Re: [PATCH] Fixed a pathing issue with objdump and grep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 09:57:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adam Stylinski <adam.stylinski@...gent.com>
Cc:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Taeung Song <treeze.taeung@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed a pathing issue with objdump and grep

Em Wed, May 03, 2017 at 12:12:23PM +0000, Adam Stylinski escreveu:
> The path fed to the argument for objdump used in the perf-annotate
> feature didn't escape spaces. The subsequent argument to grep for
> the name of the DSO containing symbols also assumed no spaces existed
> in the pathname, so grep also parsed these as extra positional
> arguments.

This one didn't apply to tip/perf/urgent, so I tried another patch
addressing the same issue, from Ravi Bangoria, and it applied, ok?

Please take a look at:

 http://lkml.kernel.org/r/20170505101417.2117-1-ravi.bangoria@linux.vnet.ibm.com

- Arnaldo
 
> Signed-off-by: Adam E Stylinski <adam.stylinski@...gent.com>
> ---
>  tools/perf/util/annotate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 7aa57225cbf7..fc5a96d584f2 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1441,7 +1441,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na
>     snprintf(command, sizeof(command),
>          "%s %s%s --start-address=0x%016" PRIx64
>          " --stop-address=0x%016" PRIx64
> -        " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand",
> +        " -l -d %s %s -C \"%s\" 2>/dev/null|grep -v \"%s\"|expand",
>          objdump_path ? objdump_path : "objdump",
>          disassembler_style ? "-M " : "",
>          disassembler_style ? disassembler_style : "",
> -- 
> 2.12.2