linux-kernel - [PATCH] Fixed issue in perf annotate with unescaped spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 5 May 2017 14:58:55 +0000
From:   Adam Stylinski <adam.stylinski@...gent.com>
To:     "acme@...nel.org" <acme@...nel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] Fixed issue in perf annotate with unescaped spaces

Perf annotate was calling both objdump and grep with arguments that
didn't escape spaces, causing perf annotate to fail on DSOs which
had spaces in their paths. This wraps those arguments in quotes.
---
 tools/perf/util/annotate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)




diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 683f8340460c..5359a42ebd6e 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1429,7 +1429,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na
    snprintf(command, sizeof(command),
         "%s %s%s --start-address=0x%016" PRIx64
         " --stop-address=0x%016" PRIx64
-        " -l -d %s %s -C %s 2>/dev/null|grep -v %s:|expand",
+        " -l -d %s %s -C \"%s\" 2>/dev/null|grep -v \"%s\":|expand",
         objdump_path ? objdump_path : "objdump",
         disassembler_style ? "-M " : "",
         disassembler_style ? disassembler_style : "",
-- 
2.12.2