linux-kernel - Re: [PATCH] iommu: Fix incompatible arg type passed to iommu_get/put_resv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 May 2017 00:48:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Manoj Iyer <manoj.iyer@...onical.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] iommu: Fix incompatible arg type passed to
 iommu_get/put_resv_regions

Hi Manoj,

[auto build test ERROR on iommu/next]
[also build test ERROR on v4.11 next-20170505]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Manoj-Iyer/iommu-Fix-incompatible-arg-type-passed-to-iommu_get-put_resv_regions/20170507-153552
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-kexec (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/iommu/iommu.c: In function 'iommu_get_group_resv_regions':
>> drivers/iommu/iommu.c:262:26: error: passing argument 1 of 'iommu_get_resv_regions' from incompatible pointer type [-Werror=incompatible-pointer-types]
      iommu_get_resv_regions(&device->dev, &dev_resv_regions);
                             ^
   In file included from drivers/iommu/iommu.c:28:0:
   include/linux/iommu.h:297:13: note: expected 'struct device *' but argument is of type 'struct device **'
    extern void iommu_get_resv_regions(struct device *dev, struct list_head *list);
                ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/iommu/iommu.c:264:26: error: passing argument 1 of 'iommu_put_resv_regions' from incompatible pointer type [-Werror=incompatible-pointer-types]
      iommu_put_resv_regions(&device->dev, &dev_resv_regions);
                             ^
   In file included from drivers/iommu/iommu.c:28:0:
   include/linux/iommu.h:298:13: note: expected 'struct device *' but argument is of type 'struct device **'
    extern void iommu_put_resv_regions(struct device *dev, struct list_head *list);
                ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/iommu_get_resv_regions +262 drivers/iommu/iommu.c

   256	
   257		mutex_lock(&group->mutex);
   258		list_for_each_entry(device, &group->devices, list) {
   259			struct list_head dev_resv_regions;
   260	
   261			INIT_LIST_HEAD(&dev_resv_regions);
 > 262			iommu_get_resv_regions(&device->dev, &dev_resv_regions);
   263			ret = iommu_insert_device_resv_regions(&dev_resv_regions, head);
 > 264			iommu_put_resv_regions(&device->dev, &dev_resv_regions);
   265			if (ret)
   266				break;
   267		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25159 bytes)