lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 7 May 2017 08:52:40 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gideon Sheril <elmocia@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        rvarsha016@...il.com, julia.lawall@...6.fr, alan@...ux.intel.com,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c

On Sat, May 06, 2017 at 03:56:23PM +0300, Gideon Sheril wrote:
>  int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
> -                                struct camera_sensor_platform_data *plat_data,
> -                                enum intel_v4l2_subdev_type type)
> +	struct camera_sensor_platform_data *plat_data,
> +	enum intel_v4l2_subdev_type type)

It was aligned properly before, it just used spaces instead of tabs.

> +		dev_info(&client->dev,
> +			"camera pdata: port: %d lanes: %d order: %8.8x\n",
> +			port, lanes, bayer_order);

This introduces a checkpatch.pl warning.  Do it like this:

[tab][tab][tab][space]"camera pdata: port: %d lanes: %d order: %8.8x\n",

regards,
dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ