linux-kernel - Re: [PATCH] thermal: core: make thermal_emergency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 May 2017 09:05:31 +0530
From:   Keerthy <j-keerthy@...com>
To:     Colin King <colin.king@...onical.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        <linux-pm@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal: core: make thermal_emergency_poweroff static



On Monday 08 May 2017 04:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Making thermal_emergency_poweroff static fixes sparse warning:
> 
>   drivers/thermal/thermal_core.c:6: warning: symbol
>   'thermal_emergency_poweroff' was not declared. Should it be static?

Acked-by: Keerthy <j-keerthy@...com>

> 
> Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/thermal/thermal_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index b21b9cc2c8d6..5a51c740e372 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -359,7 +359,7 @@ static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work,
>   * This may be called from any critical situation to trigger a system shutdown
>   * after a known period of time. By default this is not scheduled.
>   */
> -void thermal_emergency_poweroff(void)
> +static void thermal_emergency_poweroff(void)
>  {
>  	int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
>  	/*
>