linux-kernel - Re: [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 May 2017 14:06:27 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     Dong Aisheng <aisheng.dong@....com>, linux-serial@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        gregkh <gregkh@...uxfoundation.org>, jslaby@...e.com,
        Fugang Duan <fugang.duan@....com>, Mingkai.Hu@....com,
        yangbo.lu@....com
Subject: Re: [PATCH 1/6] tty: serial: lpuart: introduce lpuart_soc_data to
 represent SoC property

Hi Stefan,

On Wed, May 10, 2017 at 11:50 AM, Stefan Agner <stefan@...er.ch> wrote:
> On 2017-05-09 00:50, Dong Aisheng wrote:
>> This is used to dynamically check the SoC specific lpuart properies.
>> Currently only the checking of 32 bit register width is added which
>> functions the same as before. More will be added later for supporting
>> new chips.
>>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Jiri Slaby <jslaby@...e.com>
>> Cc: Fugang Duan <fugang.duan@....com>
>> Cc: Stefan Agner <stefan@...er.ch>
>> Cc: Mingkai Hu <Mingkai.Hu@....com>
>> Cc: Yangbo Lu <yangbo.lu@....com>
>> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
>> ---
>>  drivers/tty/serial/fsl_lpuart.c | 25 ++++++++++++++++++-------
>>  1 file changed, 18 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
>> index 15df1ba7..cd4e905 100644
>> --- a/drivers/tty/serial/fsl_lpuart.c
>> +++ b/drivers/tty/serial/fsl_lpuart.c
>> @@ -258,13 +258,21 @@ struct lpuart_port {
>>       wait_queue_head_t       dma_wait;
>>  };
>>
>> +struct lpuart_soc_data {
>> +     bool    is_32;
>> +};
>> +
>> +static struct lpuart_soc_data vf_data = {
>> +     .is_32 = false,
>> +};
>> +
>> +static struct lpuart_soc_data ls_data = {
>> +     .is_32 = true,
>> +};
>
> This could be const I guess?
>

Yes, of course.
Thanks for the pointing out.

Regards
Dong Aisheng

> --
> Stefan
>
>> +
>>  static const struct of_device_id lpuart_dt_ids[] = {
>> -     {
>> -             .compatible = "fsl,vf610-lpuart",
>> -     },
>> -     {
>> -             .compatible = "fsl,ls1021a-lpuart",
>> -     },
>> +     { .compatible = "fsl,vf610-lpuart", .data = &vf_data, },
>> +     { .compatible = "fsl,ls1021a-lpuart", .data = &ls_data, },
>>       { /* sentinel */ }
>>  };
>>  MODULE_DEVICE_TABLE(of, lpuart_dt_ids);
>> @@ -1971,6 +1979,9 @@ static struct uart_driver lpuart_reg = {
>>
>>  static int lpuart_probe(struct platform_device *pdev)
>>  {
>> +     const struct of_device_id *of_id = of_match_device(lpuart_dt_ids,
>> +                                                        &pdev->dev);
>> +     const struct lpuart_soc_data *sdata = of_id->data;
>>       struct device_node *np = pdev->dev.of_node;
>>       struct lpuart_port *sport;
>>       struct resource *res;
>> @@ -1988,7 +1999,7 @@ static int lpuart_probe(struct platform_device *pdev)
>>               return ret;
>>       }
>>       sport->port.line = ret;
>> -     sport->lpuart32 = of_device_is_compatible(np, "fsl,ls1021a-lpuart");
>> +     sport->lpuart32 = sdata->is_32;
>>
>>       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>       sport->port.membase = devm_ioremap_resource(&pdev->dev, res);