linux-kernel - Re: [PATCH] target/iscsi: make function target_parse_xcopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 May 2017 13:55:58 +0000
From:   Bart Van Assche <Bart.VanAssche@...disk.com>
To:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static

On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Making target_parse_xcopy_cmd static fixes sparse warning:
> 
> "warning: symbol 'target_parse_xcopy_cmd' was not declared.  Should
> it be static?"
> 
> Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/target/target_core_xcopy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
> index aecb36d955f0..00e0269e6be4 100644
> --- a/drivers/target/target_core_xcopy.c
> +++ b/drivers/target/target_core_xcopy.c
> @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work)
>   * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing
>   * fails.
>   */
> -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
> +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
>  {
>  	struct se_cmd *se_cmd = xop->xop_se_cmd;
>  	unsigned char *p = NULL, *seg_desc;

Hello Colin,

Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the
XCOPY code and session shutdown".

Bart.