linux-kernel - Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next line

Open Source and information security mailing list archives

Date:   Sun, 14 May 2017 21:20:48 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Maciek Fijalkowski <macfij7@...pl>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 1/3] Fix ERROR: trailing statements should be on next
 line

On Mon, 15 May 2017 05:58:05 +0300
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> On Sun, May 14, 2017 at 07:51:28PM +0200, Maciek Fijalkowski wrote:
> > From: Maciej Fijalkowski <macfij7@...pl>
> > 
> > Signed-off-by: Maciej Fijalkowski <macfij7@...pl>  
> 
> I prefer the original form - ; isn't a full statement.
> 
> > ---
> >  drivers/net/virtio_net.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> > index 9320d96..f20dfb8 100644
> > --- a/drivers/net/virtio_net.c
> > +++ b/drivers/net/virtio_net.c
> > @@ -217,7 +217,8 @@ static void give_pages(struct receive_queue *rq, struct page *page)
> >  	struct page *end;
> >  
> >  	/* Find end of list, sew whole thing into vi->rq.pages. */
> > -	for (end = page; end->private; end = (struct page *)end->private);
> > +	for (end = page; end->private; end = (struct page *)end->private)
> > +		;

FWIW, I generally like to put a comment on the next line to make it
abundantly clear that there's nothing in the body of the loop, it's
also more aesthetically pleasing than a semi-colon on the line by
itself, ex. /* Nothing */;  It's just too easy to misinterpret the
loop otherwise, especially without gratuitous white space.  Thanks,

Alex

> >  	end->private = (unsigned long)rq->pages;
> >  	rq->pages = page;
> >  }
> > -- 
> > 2.4.11  
> _______________________________________________
> Virtualization mailing list
> Virtualization@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives