linux-kernel - Re: [PATCH] PM / Domains: pdd->dev can't be NULL in genpd_dev_pm_qos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 08:46:06 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>,
        Kevin Hilman <khilman@...nel.org>, Pavel Machek <pavel@....cz>,
        Len Brown <len.brown@...el.com>,
        linaro-kernel <linaro-kernel@...ts.linaro.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] PM / Domains: pdd->dev can't be NULL in genpd_dev_pm_qos_notifier()

On 16 May 2017 at 07:22, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> The pm_domain_data (pdd) pointer is set from genpd_alloc_dev_data() and
> pdd->dev is guaranteed to be valid. There is no need to check pdd and
> pdd->dev in rest of the code as pdd->dev will always be valid for a non
> NULL pdd pointer.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index da49a8383dc3..71c95ad808d5 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -443,7 +443,7 @@ static int genpd_dev_pm_qos_notifier(struct notifier_block *nb,
>
>                 pdd = dev->power.subsys_data ?
>                                 dev->power.subsys_data->domain_data : NULL;
> -               if (pdd && pdd->dev) {
> +               if (pdd) {
>                         to_gpd_data(pdd)->td.constraint_changed = true;
>                         genpd = dev_to_genpd(dev);
>                 } else {
> --
> 2.13.0.303.g4ebf3021692d
>