linux-kernel - Re: [alsa-devel] future of sounds/oss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 10:44:57 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Christoph Hellwig <hch@....de>, Jaroslav Kysela <perex@...ex.cz>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Linux/m68k" <linux-m68k@...r.kernel.org>
Subject: Re: [alsa-devel] future of sounds/oss

On Tue, 16 May 2017 09:45:04 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Fri, May 12, 2017 at 10:01 AM, Takashi Iwai <tiwai@...e.de> wrote:
> >> > But, looking at the tree again, I noticed that ALSA isn't built yet at
> >> > all for m68k.  I don't remember why it's disabled.
> >> > Jaroslav, do you know the reason behind it?
> >>
> >> Because ALSA doesn't have any drivers that can be used on m68k platforms?
> >
> > But we have virtual and generic drivers (such as UART support), so
> > there seems no reason to stop it.  Maybe the lack of proper MMU
> 
> It seems to date back to the move of sound from arch/*/Kconfig
> to sound/Kconfig. I guess at that time there was just no use for ALSO on
> m68k.
> 
> > support was the reason?  Let's try to cross-build...
> 
> Building seems to work fine...

Worked fine with my cross-build test, too.
OK, let's enable the build on 4.13.  The patch is attached below.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] ALSA: Enable build with m68k

By some reason in the ancient history, we disabled the build of ALSA
drivers for m68k.  Since we'd like to move sound/oss/dmasound stuff
into ALSA for the complete drop of the legacy OSS stuff, let's try to
start building with m68k.

Signed-off-by: Takashi Iwai <tiwai@...e.de>
---
 sound/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/Kconfig b/sound/Kconfig
index ee2e69a9ecd1..6437e398b08e 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -56,7 +56,7 @@ config SOUND_OSS_CORE_PRECLAIM
 
 source "sound/oss/dmasound/Kconfig"
 
-if !M68K && !UML
+if !UML
 
 menuconfig SND
 	tristate "Advanced Linux Sound Architecture"
@@ -124,7 +124,7 @@ source "sound/oss/Kconfig"
 
 endif # SOUND_PRIME
 
-endif # !M68K
+endif # !UML
 
 endif # SOUND
 
-- 
2.12.2