linux-kernel - Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 14:34:46 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        andrew@...n.ch, jason@...edaemon.net, jaz@...ihalf.com,
        will.deacon@....com, nadavh@...vell.com, robh+dt@...nel.org,
        neta@...vell.com, tn@...ihalf.com,
        gregory.clement@...e-electrons.com, mark.rutland@....com,
        sebastian.hesselbarth@...il.com
Subject: Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board
 description

Hello,

On Tue, 16 May 2017 01:28:32 +0200, Marcin Wojtas wrote:

> +&cps_eth1 {
> +	status = "okay";
> +	phy = <&phy0>;
> +	phy-mode = "sgmii";
> +};

It would be nice to indicate which connector is that, like is done in
the rest of this Device Tree file.

> +&ap_sdhci0 {
> +	status = "okay";
> +	bus-width = <8>;
> +	no-1-8-v;
> +	non-removable;
> +};
> +
> +&cpm_sdhci0 {
> +	status = "okay";
> +	bus-width = <4>;
> +	no-1-8-v;
> +	non-removable;
> +};

Same comment. Also, are they both really non-removable? I have a uSD
card connector on my MacchiatoBin board. It isn't covered by those new
entries ?

Also, fix the wording of MacchiatoBin in your commit title/commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com