linux-kernel - [PATCH] rtc-88pm80x: Delete an error message for a failed memory allocation in pm80x_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 15:01:40 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     rtc-linux@...glegroups.com,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Chao Xie <chao.xie@...vell.com>,
        Vaibhav Hiremath <vaibhav.hiremath@...aro.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: [PATCH] rtc-88pm80x: Delete an error message for a failed memory
 allocation in pm80x_rtc_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 16 May 2017 14:54:13 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/rtc/rtc-88pm80x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c
index 466bf7f9a285..ae0e2561ecfa 100644
--- a/drivers/rtc/rtc-88pm80x.c
+++ b/drivers/rtc/rtc-88pm80x.c
@@ -266,10 +266,8 @@ static int pm80x_rtc_probe(struct platform_device *pdev)
 
 	if (!pdata) {
 		pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
-		if (!pdata) {
-			dev_err(&pdev->dev, "failed to allocate memory\n");
+		if (!pdata)
 			return -ENOMEM;
-		}
 	}
 
 	info =
-- 
2.13.0