linux-kernel - Re: [patch 07/18] ACPI: Adjust system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 20:13:15 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, linux-acpi@...r.kernel.org,
        Len Brown <lenb@...nel.org>
Subject: Re: [patch 07/18] ACPI: Adjust system_state check

On Mon, 15 May 2017, Steven Rostedt wrote:

> 
> [ added linux-acpi and took off arm list ;-) ]
> 
> On Sun, 14 May 2017 20:27:23 +0200
> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> > required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> > 
> > Make the decision wether a pci root is hotplugged depend on SYSTEM_RUNNING
> > instead of !SYSTEM_BOOTING.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Catalin Marinas <catalin.marinas@....com>
> > Cc: Will Deacon <will.deacon@....com>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: linux-arm-kernel@...ts.infradead.org
> > ---
> >  drivers/acpi/pci_root.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/drivers/acpi/pci_root.c
> > +++ b/drivers/acpi/pci_root.c
> > @@ -523,7 +523,7 @@ static int acpi_pci_root_add(struct acpi
> >  	struct acpi_pci_root *root;
> >  	acpi_handle handle = device->handle;
> >  	int no_aspm = 0;
> > -	bool hotadd = system_state != SYSTEM_BOOTING;
> > +	bool hotadd = system_state == SYSTEM_RUNNING;
> 
> What about the other boot states greater than SYSTEM_RUNNING? Can this
> be called then too?
> 
> IOW, should it be:
> 
> 	bool hotadd = system_state >= SYSTEM_RUNNING;

Greater than RUNNING is HALT,POWEROFF,RESTART. Having a PCI hotplug event
there would be interesting :) I'll amend the changelog.

Thanks,

	tglx