linux-kernel - Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 18:50:16 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [patch V2 17/17] sched: Enable might_sleep() and
 smp_processor_id() checks early

On Wed, 17 May 2017 00:46:37 +0200 (CEST)
Thomas Gleixner <tglx@...utronix.de> wrote:


> > > --- a/lib/smp_processor_id.c
> > > +++ b/lib/smp_processor_id.c
> > > @@ -28,7 +28,7 @@ notrace static unsigned int check_preemp
> > >  	/*
> > >  	 * It is valid to assume CPU-locality during early bootup:
> > >  	 */
> > > -	if (system_state != SYSTEM_RUNNING)
> > > +	if (system_state < SYSTEM_SCHEDULING)  
> > 
> > Do we want to ignore halting or rebooting too?  
> 
> I don't think so. After setting those states, interesting stuff like
> device_shutdown() gets invoked. We want the coverage there.

Then I'd suggest that you update the change log, as this patch also
adds coverage to those states as well.

-- Steve