linux-kernel - RE: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 10:08:15 +0000
From:   Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "liudongdong (C)" <liudongdong3@...wei.com>
Subject: RE: [PATCH v2 1/2] PCI/portdrv: add support for different MSI
 interrupts for PCIe port services

Hi Christoph

> -----Original Message-----
> From: linux-pci-owner@...r.kernel.org [mailto:linux-pci-
> owner@...r.kernel.org] On Behalf Of Christoph Hellwig
> Sent: 18 May 2017 10:27
> To: Gabriele Paoloni
> Cc: bhelgaas@...gle.com; helgaas@...nel.org; Linuxarm; linux-
> pci@...r.kernel.org; lukas@...ner.de; linux-kernel@...r.kernel.org;
> mika.westerberg@...ux.intel.com; hch@...radead.org; liudongdong (C)
> Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI
> interrupts for PCIe port services
> 
> > - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for
> given port
> > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as
> interrupt mode
> > + * for given port
> 
> just rename it to pcie_port_enable_vecs to avoid the overly long line..

The function is actually renamed but I missed to update the comment, my bad.

> 
> > +		 * pci_irq_vector() below is able to handle entry
> differently
> > +		 * depending on MSI vs MSI-x case
> 
> As mentioned in the review for the other patch:  no need to repeat
> this for every user of pci_irq_vector.

I also missed to remove this comment

> 
> Otherwise this looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Many thanks
I'll fix comments and send out v3 straight

Cheers
Gab