linux-kernel - Re: [PATCH] gpu: host1x: select IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 May 2017 11:05:20 -0400
From:   Sean Paul <seanpaul@...omium.org>
To:     Mikko Perttunen <cyndis@...si.fi>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Thierry Reding <thierry.reding@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: host1x: select IOMMU_IOVA

On Thu, Apr 20, 2017 at 09:47:35AM +0300, Mikko Perttunen wrote:
> Ah, had to forget something :)
> 
> Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>

Applied to -misc-fixes, thank you

Sean


> 
> On 19.04.2017 21:24, Arnd Bergmann wrote:
> > When IOMMU_IOVA is not built-in but host1x is, we get a link error:
> > 
> > drivers/gpu/host1x/dev.o: In function `host1x_remove':
> > dev.c:(.text.host1x_remove+0x50): undefined reference to `put_iova_domain'
> > drivers/gpu/host1x/dev.o: In function `host1x_probe':
> > dev.c:(.text.host1x_probe+0x31c): undefined reference to `init_iova_domain'
> > dev.c:(.text.host1x_probe+0x38c): undefined reference to `put_iova_domain'
> > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_init':
> > cdma.c:(.text.host1x_cdma_init+0x238): undefined reference to `alloc_iova'
> > cdma.c:(.text.host1x_cdma_init+0x2c0): undefined reference to `__free_iova'
> > drivers/gpu/host1x/cdma.o: In function `host1x_cdma_deinit':
> > cdma.c:(.text.host1x_cdma_deinit+0xb0): undefined reference to `free_iova'
> > 
> > This adds the same select statement that we have for drm_tegra.
> > 
> > Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/gpu/host1x/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> > index b2fd029d67b3..91916326957f 100644
> > --- a/drivers/gpu/host1x/Kconfig
> > +++ b/drivers/gpu/host1x/Kconfig
> > @@ -1,6 +1,7 @@
> >  config TEGRA_HOST1X
> >  	tristate "NVIDIA Tegra host1x driver"
> >  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> > +	select IOMMU_IOVA if IOMMU_SUPPORT
> >  	help
> >  	  Driver for the NVIDIA Tegra host1x hardware.
> > 
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sean Paul, Software Engineer, Google / Chromium OS