linux-kernel - Re: [PATCH 1/1] spi: imx: fix issue when tx_buf or rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 16:15:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Chris Ruehl <chris.ruehl@...ys.com.hk>
Cc:     Jiada Wang <jiada_wang@...tor.com>,
        Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        leonard.crestez@....com
Subject: Re: [PATCH 1/1] spi: imx: fix issue when tx_buf or rx_buf is NULL

On Fri, May 19, 2017 at 3:45 PM, Chris Ruehl <chris.ruehl@...ys.com.hk> wrote:
> On Thursday, May 18, 2017 06:01 PM, jiada_wang@...tor.com wrote:

> But I think we missing something here. We return from a void function()
> so the error keeps hidden. The root cause is calling this functions with a
> NULL pointer. See if you can fix this by find the caller and check if the
> parameter hand over are valid.

AFAIU some SPI controllers can have half-duplex protocol, in which the
second buffer might be absent.


> Disclaimer: http://www.gtsys.com.hk/email/classified.html

Just wondering if it's okay to have this type of footer in open source
community's mailing lists.

-- 
With Best Regards,
Andy Shevchenko