linux-kernel - Re: [PATCH v2 9/9] crypto: ccp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 15:32:09 -0500
From:   Gary R Hook <gary.hook@....com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "arno@...isbad.org" <arno@...isbad.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "giovanni.cabiddu@...el.com" <giovanni.cabiddu@...el.com>,
        "salvatore.benedetto@...el.com" <salvatore.benedetto@...el.com>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "qat-linux@...el.com" <qat-linux@...el.com>
Subject: Re: [PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant

On 5/19/2017 1:53 AM, Corentin Labbe wrote:
> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Acked-by: Gary R Hook <gary.hook@....com>

> ---
>   drivers/crypto/ccp/ccp-crypto-sha.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c 
> b/drivers/crypto/ccp/ccp-crypto-sha.c
> index 6b46eea94932..ce97b3868f4a 100644
> --- a/drivers/crypto/ccp/ccp-crypto-sha.c
> +++ b/drivers/crypto/ccp/ccp-crypto-sha.c
> @@ -18,6 +18,7 @@
>   #include <linux/crypto.h>
>   #include <crypto/algapi.h>
>   #include <crypto/hash.h>
> +#include <crypto/hmac.h>
>   #include <crypto/internal/hash.h>
>   #include <crypto/sha.h>
>   #include <crypto/scatterwalk.h>
> @@ -308,8 +309,8 @@ static int ccp_sha_setkey(struct crypto_ahash *tfm, 
> const u8 *key,
>           }
> 
>           for (i = 0; i < block_size; i++) {
> -               ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ 0x36;
> -               ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ 0x5c;
> +               ctx->u.sha.ipad[i] = ctx->u.sha.key[i] ^ HMAC_IPAD_VALUE;
> +               ctx->u.sha.opad[i] = ctx->u.sha.key[i] ^ HMAC_OPAD_VALUE;
>           }
> 
>           sg_init_one(&ctx->u.sha.opad_sg, ctx->u.sha.opad, block_size);
> -- 
> 2.13.0
>