linux-kernel - Re: [PATCH v6] mfd: Add Cherry Trail Whiskey Cove PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2017 15:21:19 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, Bin Gao <bin.gao@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v6] mfd: Add Cherry Trail Whiskey Cove PMIC driver

On Mon, May 15, 2017 at 2:20 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> Hi,
>
> This is actually v7, with the following changes:
>
> Changes in v7:
> -Add explanation why this is a bool and why it selects i2c-designwaree
>  to the help text rather then as comments in the Kconfig

I just noticed the changelog says it was updated to be
buildable as a module but the Kconfig is still "bool"...

Guessing this was just an oversight since there is
code for modular use in the driver itself.

Paul.
--

>
> Regards,
>
> Hans
>
>
>
> On 15-05-17 20:17, Hans de Goede wrote:
>>
>> Add mfd driver for Intel CHT Whiskey Cove PMIC, based on various non
>> upstreamed CHT Whiskey Cove PMIC patches.
>>
>> This is a somewhat minimal version which adds irqchip support and cells
>> for: ACPI PMIC opregion support, the i2c-controller driving the external
>> charger irc and the pwrsrc/extcon block.
>>
>> Further cells can be added in the future if/when drivers are upstreamed
>> for them.
>>
>> Cc: Bin Gao <bin.gao@...el.com>
>> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> ---
>> Changes in v2:
>> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
>>   its own Kconfig and allow this to be built as a module

 [...]

>> +};
>> +MODULE_DEVICE_TABLE(i2c, cht_wc_i2c_id);
>> +
>> +static const struct acpi_device_id cht_wc_acpi_ids[] = {
>> +       { "INT34D3", },
>> +       { }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, cht_wc_acpi_ids);
>> +
>> +static struct i2c_driver cht_wc_driver = {
>> +       .driver = {
>> +               .name   = "CHT Whiskey Cove PMIC",
>> +               .pm     = &cht_wc_pm_ops,
>> +               .acpi_match_table = ACPI_PTR(cht_wc_acpi_ids),
>> +       },
>> +       .probe = cht_wc_probe,
>> +       .shutdown = cht_wc_shutdown,
>> +       .id_table = cht_wc_i2c_id,
>> +};
>> +
>> +module_i2c_driver(cht_wc_driver);
>> +
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_AUTHOR("Hans de Goede <hdegoede@...hat.com>");
>>
>