linux-kernel - [PATCH] vlynq: Delete an error message for a failed memory allocation in vlynq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 20 May 2017 22:00:30 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Florian Fainelli <f.fainelli@...il.com>,
        kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: [PATCH] vlynq: Delete an error message for a failed memory allocation
 in vlynq_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 20 May 2017 21:53:55 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/vlynq/vlynq.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index c0227f9418eb..08173463e7eb 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -684,11 +684,8 @@ static int vlynq_probe(struct platform_device *pdev)
 		return -ENODEV;
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-	if (!dev) {
-		printk(KERN_ERR
-		       "vlynq: failed to allocate device structure\n");
+	if (!dev)
 		return -ENOMEM;
-	}
 
 	dev->id = pdev->id;
 	dev->dev.bus = &vlynq_bus_type;
-- 
2.13.0