linux-kernel - Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 May 2017 09:09:21 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     alsa-devel@...a-project.org, Julia Lawall <julia.lawall@...6.fr>,
        perex@...ex.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

On Wed, 17 May 2017 14:33:45 +0200,
Bhumika Goyal wrote:
> 
> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai <tiwai@...e.de> wrote:
> > On Wed, 17 May 2017 13:38:56 +0200,
> > Bhumika Goyal wrote:
> >>
> >> Declare snd_kcontrol_new structures as const as they are only passed an
> >> argument to the function snd_ctl_new1. This argument is of type const,
> >> so snd_kcontrol_new structures having this property can be made const.
> >> Done using Coccinelle:
> >>
> >> @r disable optional_qualifier@
> >> identifier x;
> >> position p;
> >> @@
> >> static struct snd_kcontrol_new x@......};
> >>
> >> @ok@
> >> identifier r.x;
> >> position p;
> >> @@
> >> snd_ctl_new1(&x@p,...)
> >>
> >> @bad@
> >> position p != {r.p,ok.p};
> >> identifier r.x;
> >> @@
> >> x@p
> >>
> >> @depends on !bad disable optional_qualifier@
> >> identifier r.x;
> >> @@
> >> +const
> >> struct snd_kcontrol_new x;
> >>
> >> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> >
> > As I already asked, could you send as a patchset if you have multiple
> > similar patches?
> >
> 
> Sure. Will combine the already sent ones and some new ones into a
> patchset and send again.

Well, since there haven't been new submissions and the patches are
trivial, I applied the existing four patches.  If you have newer ones,
please submit as a patchset.


thanks,

Takashi